Feat - Exit with Non-Zero Code on Migration Cancellation #1471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a non-zero exit code to
contentful space migrationwhen the user cancels the migration by pressing "n" at the confirmation prompt.Description
#1470 has the detailed reasoning behind this PR.
Motivation and Context
This change allows scripts to reliably detect user-cancelled migrations and take appropriate action.
Closes #1470
Caveats
I've never contributed to such CLI tools so I don't know exactly how to build and test this locally. I've run
npm testin a test space and I had 4 failures (probably because it's a free space).If someone guides me through how to build and test this locally I'd love to do that. I'd gladly add documetation regarding to that as well.