chore: [SECURITY-1357] standardize string quotes #1392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chore: standardize string quotes in workflow https://docs.github.com/en/actions/reference/security/secure-use#good-practices-for-mitigating-script-injection-attacks
forged-request
requested review from
SofiaMargariti and
maxcheremisin
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for GitHub.
3 Skipped Deployments
|
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
There was a problem hiding this comment.
Pull request overview
This PR addresses a security concern by standardizing string quotes in GitHub Actions workflows to mitigate script injection attacks. The changes move from direct expression interpolation to environment variables with proper quoting, following GitHub's security best practices.
Key changes:
- Replaced single quotes with double quotes for YAML string values (descriptions, step names, node version)
- Migrated inline GitHub context expressions (
${{ }}) to environment variables to prevent shell injection - Added proper quoting around shell variable references in conditional statements
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/vercel.yaml | Standardized quotes and moved GitHub context values to environment variables for three Vercel deployment steps |
| .github/workflows/publish.yaml | Standardized quotes and secured shell script by using environment variables instead of inline expressions |
| .github/workflows/build.yaml | Standardized quotes and moved ref_name to environment variable in echo step |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.github/workflows/publish.yaml
Outdated
| - name: 'Merge changes downstream' | ||
| if: ${{ !inputs.publish-prerelease }} | ||
| - name: "Merge changes downstream" | ||
| if: ${{ !inputs.publish-prelease }} |
There was a problem hiding this comment.
Corrected spelling of 'prelease' to 'prerelease'.
Chaoste
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chore: standardize string quotes in workflow