feat: refactor file handling to use FSPath for temporary file creation

[butschster]

fix #168

Summary by CodeRabbit

• Refactor
  • Improved internal file handling to enhance the robustness and reliability of temporary file management.
  • Enhanced logging functionality to provide more detailed context about the source being processed.
  • Reduced dependencies in the TreeSourceFetcher instantiation for streamlined construction.

[coderabbitai]

Walkthrough

The changes refactor the temporary file path handling in the AbstractGitSource.php file. The code now uses FSPath::create(...)->join(...) to construct file paths instead of manual string concatenation. It also retrieves the parent directory via the parent() method on the FSPath object and writes the string representation of the temporary file rather than the object. An import for the FSPath class has been added. Additionally, the TreeSourceFetcher class's fetch method now includes an extra logging parameter for sourcePaths. Furthermore, the MCPServerCommand class now binds the DirectoriesInterface in its scope, and the TreeSourceBootloader class has reduced its method parameters.

Changes

File	Change Summary
src/.../AbstractGitSource.php	Replaced manual concatenation with FSPath::create($tempDir)->join($file), changed parent directory retrieval to use parent(), and updated the write call to use the string representation. New import for FSPath added.
src/.../TreeSourceFetcher.php	Added sourcePaths to the logging parameters in the fetch method to enhance logging functionality.
src/.../MCPServerCommand.php	Added binding for DirectoriesInterface in the runScope method.
src/.../TreeSourceBootloader.php	Removed parameters ContentBuilderFactory $builderFactory and HasPrefixLoggerInterface $logger from the defineSingletons method.

Assessment against linked issues

Objective	Addressed	Explanation
Git Diff Error: Failed to open stream: No such file or directory (#168)	✅

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)

• We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2fe1680 and 0015fb8.

📒 Files selected for processing (2)

• src/Console/MCPServerCommand.php (1 hunks)
• src/Source/Tree/TreeSourceBootloader.php (0 hunks)

💤 Files with no reviewable changes (1)

• src/Source/Tree/TreeSourceBootloader.php

⏰ Context from checks skipped due to timeout of 90000ms (5)

• GitHub Check: 📦 Build macOS (x64)
• GitHub Check: 📦 Build Windows (x64)
• GitHub Check: 📦 Build Unix Executables (linux, amd64)
• GitHub Check: 📦 Build Unix Executables (linux, arm64)
• GitHub Check: 📦 Build macOS ARM64

🔇 Additional comments (1)

src/Console/MCPServerCommand.php (1)

112-112: Good addition for dependency injection.

This change properly binds the DirectoriesInterface to make it available for injection within the MCP scope. This is consistent with the PR's objective of refactoring file handling, as components within this scope may need direct access to directory services for FSPath-based file operations.

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 52e2714 and bde3aa8.

📒 Files selected for processing (1)

• src/Source/GitDiff/Fetcher/Source/AbstractGitSource.php (2 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

src/Source/GitDiff/Fetcher/Source/AbstractGitSource.php (1)

src/Application/FSPath.php (3)

• FSPath (7-469)
• join (56-79)
• parent (178-208)

🪛 GitHub Actions: 🔍 Static analysis

src/Source/GitDiff/Fetcher/Source/AbstractGitSource.php

[error] 53-53: InvalidArgument: Argument 1 of Butschster\ContextGenerator\Source\GitDiff\Fetcher\Source_home_runner_work_generator_generator_src_Source_GitDiff_Fetcher_Source_AbstractGitSource_php_53_1802::__construct expects string, but Butschster\ContextGenerator\Application\FSPath provided (see https://psalm.dev/004)

🔇 Additional comments (3)

src/Source/GitDiff/Fetcher/Source/AbstractGitSource.php (3)

7-7: LGTM: Added import for FSPath class

The FSPath import is correctly added to use the class for handling file paths in a more structured way.

---

46-47: LGTM: Improved file path handling

Good refactoring to use the FSPath class for file path construction and parent directory retrieval. This approach is safer and more maintainable than manual string concatenation.

---

50-50: LGTM: Correctly casting FSPath to string

The FSPath object is properly cast to string before being passed to the write method.