Skip to content

Replace FSPath implementation #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Replace FSPath implementation #205

wants to merge 2 commits into from

Conversation

roxblnfk
Copy link
Collaborator

Try to replace FSPath with the new inplementation from dload.
Key features:

  • always normalizes path to '/'
  • always non-empty-string in the path
  • checks isDir/isFile without unnecessary IO in some cases

todo: cover FSPath::parent() with tests

@roxblnfk roxblnfk marked this pull request as draft April 22, 2025 15:53
@roxblnfk roxblnfk closed this Apr 22, 2025
@butschster butschster deleted the fspath branch April 27, 2025 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant