-
Notifications
You must be signed in to change notification settings - Fork 6
fix: handle case when no documents are found in configuration #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
butschster
commented
Apr 26, 2025
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the issue where an error was thrown when no documents were found in the configuration by ensuring that test fixtures exist and updating workflow configurations for proper PHP extension support.
- Added YAML fixtures for document configuration handling ("basic", "filtered", and "content-filter").
- Updated GitHub workflow configuration files to include the "fileinfo" PHP extension.
Reviewed Changes
Copilot reviewed 44 out of 57 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
tests/fixtures/Console/GenerateCommand/FileSource/filtered.yaml | Added fixture for filtered file source test |
tests/fixtures/Console/GenerateCommand/FileSource/content-filter.yaml | Added fixture for testing content filtering |
tests/fixtures/Console/GenerateCommand/FileSource/basic.yaml | Added basic file source test fixture |
.github/workflows/testing.yml | Updated PHP extensions by adding "fileinfo" |
.github/workflows/static-analysis.yml | Updated PHP extensions by adding "fileinfo" |
.github/workflows/security.yml | Updated PHP extensions by adding "fileinfo" |
.github/workflows/refactoring.yml | Updated PHP extensions by adding "fileinfo" |
Files not reviewed (13)
- composer.json: Language not supported
- src/Application/Bootloader/VariableBootloader.php: Language not supported
- src/Config/Import/Source/Url/UrlImportSource.php: Language not supported
- src/Config/Reader/YamlReader.php: Language not supported
- src/Console/GenerateCommand.php: Language not supported
- src/Directories.php: Language not supported
- src/DirectoriesInterface.php: Language not supported
- src/Document/Compiler/CompiledDocument.php: Language not supported
- src/Document/Compiler/DocumentCompiler.php: Language not supported
- src/McpServer/Console/MCPServerCommand.php: Language not supported
- src/McpServer/Prompt/Extension/TemplateResolver.php: Language not supported
- src/McpServer/Prompt/PromptRegistry.php: Language not supported
- tests/fixtures/Console/GenerateCommand/FileSource/TestClass.php: Language not supported
…tifx/generate-command