fix: Add _version.py to .gitignore and handle in workflow#11
Merged
turbomam merged 1 commit intoJul 15, 2025
Merged
Conversation
- Add src/weather_mcp/_version.py to .gitignore - Remove _version.py from git tracking (should be generated) - Add git update-index --skip-worktree in workflow to prevent dirty state - Resolves version mismatch caused by modified version file during build 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the generated _version.py from version control and adjusts the CI workflow to prevent dirty states when building the package.
- Deletes
src/weather_mcp/_version.pyso it’s no longer tracked by Git - Updates the
publish.ymlworkflow to mark the version file as skipped before runninghatch build
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/weather_mcp/_version.py | Entire file deleted (generated by setuptools-scm) |
| .github/workflows/publish.yml | Added git update-index --skip-worktree step before the build |
Comments suppressed due to low confidence (2)
.github/workflows/publish.yml:63
- Consider removing
|| trueso that any failures ingit update-indexsurface immediately in CI rather than being silently ignored.
git update-index --skip-worktree src/weather_mcp/_version.py || true
.github/workflows/publish.yml:63
- After the build step, run
git update-index --no-skip-worktree src/weather_mcp/_version.pyto restore normal tracking and avoid leaving the index in a modified state.
git update-index --skip-worktree src/weather_mcp/_version.py || true
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code