Fix Coins not parsing with Invariant Culture #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

Homosanians wants to merge 1 commit into continuation-team:dev from Homosanians:dev

Homosanians commented Jan 28, 2025

Solution for #134

Other options should be considered too, as exception handling is not CPU efficient:

Use invariant culture only (especially if project already has in-house culture logic, e..g string str = value?.ToString().Replace(",", "."); in Coins constructor)
Compare current culture to invariant in the 2 methods involved. i.e. CultureInfo.CurrentCulture == CultureInfo.InvariantCulture

Relatively to the Issue, the tests are passed.


          Fix Coins not parsing with Invariant Culture

abb6afc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet