V2.0.0a api fix #2 - refix the broken API pipeline #480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
March 6, 2024 14:08
…gle image controlnet input
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit of #468 seems to break the APi pipelines again.
The primary cause of the problem is that "setattr" sections cannot be removed as those extra attributes don't exist in the default ControlNetUnit class defined in sd-webui-controlnet, and "setattr" will add the new attributes (which only exist in the UiControlNet class) to the object in a hacky way. To remove them, there will need to be a change in the sd-webui-control which I don't bother to make right now.
Another bug is that the return of the get_controlnet_units should be cn_units_dataclass (a list of ControlNetUnit) when is_api is True
Now it can also handle the ip-adapter case (which takes a single reference image rather than batch images) together with other control net based on batch frame-wise input