Refactor: General code quality improvements #570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit includes several improvements to the AnimateDiff scripts:
- `animatediff.py`:
- Replaced wildcard import from `animatediff_i2ibatch` with explicit imports.
- Renamed `self.hacked` flag in `AnimateDiffScript` to `self.module_injected_by_this_script_run` for better clarity.
- `animatediff_mm.py`:
- Added detailed comments to the GroupNorm32 monkey patching section to explain its purpose and global nature.
- Improved consistency in UNet block index handling between `inject` and `restore` methods for `input_blocks` under `inject_sdxl` condition.
- Added cautionary comments regarding the hardcoded UNet indices, noting their dependency on specific SD UNet architectures.
- `animatediff_i2ibatch.py`:
- Standardized error logging by replacing a `print(e)` call with `logger.error()` for `UnidentifiedImageError`.
- `tests/test_animatediff_mm.py`:
- Created a new unit test file.
- Added initial test cases for `AnimateDiffMM.load()` method, covering successful load and file-not-found scenarios.
- Includes basic mocking setup for A1111/Forge environment globals.
These changes aim to improve code readability, maintainability, and provide a starting point for unit testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit includes several improvements to the AnimateDiff scripts:
animatediff.py:animatediff_i2ibatchwith explicit imports.self.hackedflag inAnimateDiffScripttoself.module_injected_by_this_script_runfor better clarity.animatediff_mm.py:injectandrestoremethods forinput_blocksunderinject_sdxlcondition.animatediff_i2ibatch.py:print(e)call withlogger.error()forUnidentifiedImageError.tests/test_animatediff_mm.py:AnimateDiffMM.load()method, covering successful load and file-not-found scenarios.These changes aim to improve code readability, maintainability, and provide a starting point for unit testing.