Skip to content

fix: HOTFIX stop agent loop if aborted/not streaming #8208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 13, 2025
Merged

fix: HOTFIX stop agent loop if aborted/not streaming #8208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64d1a45
fix: HOTFIX stop agent loop if aborted/not streaming
RomneyDa Oct 12, 2025
32f4c81
fix: extra setInactive in test
RomneyDa Oct 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion gui/src/redux/thunks/streamNormalInput.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,12 +254,17 @@ export const streamNormalInput = createAsyncThunk<

// 2. Pre-process args to catch invalid args before checking policies
const state2 = getState();
if (streamAborter.signal.aborted || !state2.session.isStreaming) {
return;
}
const generatedCalls2 = selectPendingToolCalls(state2);
await preprocessToolCalls(dispatch, extra.ideMessenger, generatedCalls2);

// 3. Security check: evaluate updated policies based on args
const state3 = getState();

if (streamAborter.signal.aborted || !state3.session.isStreaming) {
return;
}
const generatedCalls3 = selectPendingToolCalls(state3);
const toolPolicies = state3.ui.toolSettings;
const policies = await evaluateToolPolicies(
Expand All @@ -283,6 +288,9 @@ export const streamNormalInput = createAsyncThunk<
// auto stream cases increase thunk depth by 1
const state4 = getState();
const generatedCalls4 = selectPendingToolCalls(state4);
if (streamAborter.signal.aborted || !state4.session.isStreaming) {
return;
}
if (generatedCalls4.length > 0) {
// All that didn't fail are auto approved - call them
await Promise.all(
Expand Down
5 changes: 0 additions & 5 deletions gui/src/redux/thunks/streamResponse.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1068,11 +1068,6 @@ describe("streamResponseThunk", () => {
type: "session/abortStream",
payload: undefined,
},
// Stream end cleanup
{
type: "session/setInactive",
payload: undefined,
},
{
type: "chat/streamNormalInput/fulfilled",
meta: {
Expand Down
Loading