Skip to content

Conversation

@uinstinct
Copy link
Contributor

@uinstinct uinstinct commented Nov 21, 2025

Description

support for new grok 4.1

resolves CON-4961

AI Code Review

  • Team members only: AI review runs automatically when PR is opened or marked ready for review
  • Team members can also trigger a review by commenting @continue-review

Checklist

  • [] I've read the contributing guide
  • [] The relevant docs, if any, have been updated or created
  • [] The relevant tests, if any, have been updated or created

Screen recording or screenshot

[ When applicable, please include a short screen recording or screenshot - this makes it much easier for us as contributors to review and understand your changes. See this PR as a good example. ]

Tests

[ What tests were added or updated to ensure the changes work as expected? ]


Summary by cubic

Add support for xAI Grok 4.1 Fast models and update docs to recommend Grok‑4 for chat, resolving CON‑4961. Also adds Grok 4.1 Fast to CometAPI and increases Grok 4 (07‑09) context to 256k.

  • New Features
    • xAI provider: add grok-4-1-fast-reasoning, grok-4-1-fast-non-reasoning, and grok-4 (all 256k context).
    • CometAPI: add grok-4-1-fast-reasoning; bump grok-4-0709 context 128k → 256k; update description.
    • Docs: update chat role to recommend Grok‑4 with hub and YAML examples.

Written for commit 698fa69. Summary will update automatically on new commits.

@uinstinct uinstinct requested a review from a team as a code owner November 21, 2025 14:52
@uinstinct uinstinct requested review from sestinj and removed request for a team November 21, 2025 14:52
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 21, 2025
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found across 3 files

Prompt for AI agents (all 2 issues)

Understand the root cause of the following 2 issues and fix them.


<file name="packages/llm-info/src/providers/xAI.ts">

<violation number="1" location="packages/llm-info/src/providers/xAI.ts:58">
`Grok 4.1 Fast Non Reasoning` reuses the reasoning model id, so consumers will never send requests to the non‑reasoning backend. The `model` string in this block should include `-non-reasoning`.</violation>

<violation number="2" location="packages/llm-info/src/providers/xAI.ts:72">
This addition duplicates the existing `grok-4` model entry defined a few lines above, creating two identical configurations for the same model id. Remove the new block or consolidate so each model id appears only once.</violation>
</file>

Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Copy link
Collaborator

@RomneyDa RomneyDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments, also can we

  • add to the add models form in GUI
  • add it to recommended agent models i.e. make sure it gets multi edit tool
  • add comments about how the model was tested e.g. does it do well in agent mode? both CLI and extensions?
  • make sure it's added to auto tool support
  • update the docs

maxCompletionTokens: 4096,
description:
"Latest Grok model with improved reasoning and conversational abilities.",
"Latest Grok model series with improved reasoning and conversational abilities.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a specific model

Suggested change
"Latest Grok model series with improved reasoning and conversational abilities.",
"Latest Grok model with improved reasoning and conversational abilities.",

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we skip to grok 4.1 for recommended?

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

2 participants