WIP: Use avx when available. #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added x86-64 intrinsics implementation. Moved implemenation into a separate header. Added macro checks for x86. non x86 targets use 128 bit simd max. Changed intrinsic macro definition to LIBUNICODE_USE_INTRINSICS.
Yaraslaut
requested changes
Nov 3, 2024
Yaraslaut
requested changes
Nov 5, 2024
There was a problem hiding this comment.
Thanks a lot, I checked that detection is working on both linux and windows, last thing is to fix following warnings:
warning: no previous declaration for ‘void cpuid(int32_t*, int32_t, int32_t)’ [-Wmissing-declarations]
29 | void cpuid(int32_t out[4], int32_t eax, int32_t ecx)
| ^~~~~
warning: no previous declaration for ‘uint64_t xgetbv(unsigned int)’ [-Wmissing-declarations]
33 | uint64_t xgetbv(unsigned int index)
| ^~~~~~
warning: no previous declaration for ‘bool detect_os_avx()’ [-Wmissing-declarations]
45 | auto detect_os_avx() -> bool
| ^~~~~~~~~~~~~
warning: no previous declaration for ‘bool detect_os_avx512()’ [-Wmissing-declarations]
64 | auto detect_os_avx512() -> bool
| ^~~~~~~~~~~~~~~~
christianparpart
approved these changes
Nov 9, 2024
There was a problem hiding this comment.
@Dooez many thanks for your contribution. We really very much appreciate it. We've just looked together with @Yaraslaut over it. It looks overall very well implemented. Many thanks again for that.
@Yaraslaut is going to add some commit on top of it to address really minor stuff and fix the Windows platform issue. :)
Dooez
commented
Nov 10, 2024
Yaraslaut
force-pushed
the
master
branch
2 times, most recently
from
c8a6e56 to
1bf0902
Compare
Yaraslaut
approved these changes
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added runtime detection of instruction set copied from Mysticial.
Added two additional
scan_for_text_asciiwith bigger simd vector sizes and compile flags to enable the compilation.-mavx512bitalgmay be unnecessary for 512bit version.