Reworking scan API for more generic (re-)use #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christianparpart
force-pushed
the
rework-scan-api
branch
3 times, most recently
from
35cd8b1 to
7da3728
Compare
christianparpart
changed the title
christianparpart
force-pushed
the
rework-scan-api
branch
from
7da3728 to
f9c0def
Compare
christianparpart
force-pushed
the
rework-scan-api
branch
11 times, most recently
from
d071442 to
4df5e91
Compare
christianparpart
force-pushed
the
rework-scan-api
branch
from
4df5e91 to
8cce1c4
Compare
github-actions
bot
added
the
documentation
christianparpart
force-pushed
the
rework-scan-api
branch
2 times, most recently
from
42230ef to
3f32345
Compare
christianparpart
force-pushed
the
rework-scan-api
branch
9 times, most recently
from
a97b51e to
8c22d69
Compare
christianparpart
force-pushed
the
rework-scan-api
branch
10 times, most recently
from
406b4af to
dabfea4
Compare
This was referenced Mar 17, 2024
christianparpart
force-pushed
the
rework-scan-api
branch
from
dabfea4 to
e67aa17
Compare
christianparpart
force-pushed
the
rework-scan-api
branch
from
e67aa17 to
ffb35d3
Compare
christianparpart
force-pushed
the
rework-scan-api
branch
from
ffb35d3 to
238362e
Compare
…esets Signed-off-by: Christian Parpart <[email protected]>
christianparpart
force-pushed
the
rework-scan-api
branch
6 times, most recently
from
09cc6a2 to
cb0eb30
Compare
christianparpart
force-pushed
the
rework-scan-api
branch
from
cb0eb30 to
f8543bf
Compare
…g scan API Signed-off-by: Christian Parpart <[email protected]>
christianparpart
force-pushed
the
rework-scan-api
branch
from
3f9ba36 to
fbb4a9d
Compare
Yaraslaut
force-pushed
the
rework-scan-api
branch
from
5703821 to
3b705a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This API arises from the need of scanning well defined grapheme clusters (in terms of width) in a terminal grid (for Contour Terminal). The problem so far was that there were two individual code paths doing the same thing. One for fast scanning text on regular print, and a second one when assigning each individual grapheme cluster to a grid cell.
This PR aims to make sure the same code path can be used for both use cases as well as properly handling arbitrary binary (invalid UTF-8 sequences) text.