feat: add column picker to log viewer#108
feat: add column picker to log viewer#108wolffberg wants to merge 3 commits intocontrol-theory:mainfrom
Conversation
ed1d373 to
6c5de4c
Compare
|
Hey @wolffberg ! I'm trying this out, and noticed Space to toggle a column does not work (but 'x' does) Still reviewing |
|
I like the idea of configurable columns, but the changes included here are vast, and cause a lot of column sizing breakage, log line issues, etc., and some of the help around using arrow keys is either wrong or it just does not work. Perhaps reduce the changes to only allow choosing columns, and be sure to test on wide screens and dynamic changing window sizes, etc. |
destari
left a comment
There was a problem hiding this comment.
Needs a lot of work on the column sizing, truncation of log messages in the main window, help adjustments, etc. Reduce changes to the minimum
|
Regarding I agree that the changes might be a bit too broard. I'll redo the changes to reduce the scope a little. Converting to draft and will get back later this week or next week with changes 👷 I have a few questions for changes though.
|
This PR adds a custom column picker for the log viewer.
The picker is opened with
Cwhen the log viewer is active and lets you pick custom columns from a discovered list from the incoming logs.