Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0c8e0d6599
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| :beam, | ||
| :cart_pendulum, | ||
| :chain, | ||
| :dielectrophoretic_particle, | ||
| :double_oscillator, |
There was a problem hiding this comment.
Adding this exclusion block in make_list_of_problems removes nearly all previously available problems (beam/chain/glider/jackson/rocket/etc.) from LIST_OF_PROBLEMS, which means their public methods are no longer generated and their backend files are no longer included even though their metadata/model files still exist. This turns a feature addition into a broad API regression for users who call any of those problems.
Useful? React with 👍 / 👎.
ext/JuMPModels/balanced_field.jl
Outdated
| model, | ||
| begin | ||
| r[0:N], (start = r_t0) | ||
| v[0:N], (start = v_t0 + 10.0) |
There was a problem hiding this comment.
The velocity state is unconstrained here, but the dynamics later divide by v (in dγ), so the NLP domain includes points where the model is undefined (v = 0) and can produce Inf/NaN during solver trial evaluations. The metadata already defines v_min/v_max, so this missing bound is likely unintended and can cause numerical failures or unstable solves.
Useful? React with 👍 / 👎.
| K_nom = 1.0 / (pi * AR * e) | ||
|
|
||
| # model | ||
| ocp = @def begin |
There was a problem hiding this comment.
@AmielMetier @HediChennoufi nice, looks good. this code will also work for the non _s version (the one currently using a dynamics function)
4 participants
No description provided.