Skip to content

fix: name of the FluxInstance has to be "flux" #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

budimanjojo
Copy link

@budimanjojo budimanjojo commented May 26, 2025

flux-operator only accept "flux" as the metadata name of FluxInstance

ref: controlplaneio-fluxcd/flux-operator#266

flux-operator only accept "flux" as the metadata name of `FluxInstance`
@stefanprodan
Copy link
Member

This is not needed because the fullnameOverride is hardcoded in values to flux.

@budimanjojo
Copy link
Author

@stefanprodan I reported the issue in the flux-operator repo because I changed fullnameOverride in my values to something else and it broke flux for me. And now that changing the value is not permitted at all in the operator side, it makes sense to disable changing fullnameOverride at all in the charts, isn't it?

@stefanprodan
Copy link
Member

It doesn't make sense to me, if we hardcode the name in the FluxInstance then we allow for the release name to be something else, which is wrong. After the next operator version, if you change the fullnameOverride the release will fail to install, telling you the name the wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants