feat: Implement web-auth secret creation command with various options #559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@YashIIT0909 can you please signoff your commit with |
Author
Done :) |
Member
|
This PR should have a single commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new CLI command for creating Kubernetes Secrets with web UI authentication credentials, along with comprehensive tests to ensure correct behavior. The main focus is to allow users to generate and manage OAuth2 client secrets for web authentication in a flexible and user-friendly way.
New CLI command for web authentication secrets:
web-authto the CLI, enabling creation of Kubernetes Secrets containing OAuth2 client credentials. The command supports multiple ways to provide the client secret (direct input, stdin, or random generation), and includes options for annotations, labels, immutability, and YAML export. (cmd/cli/create_secret_webauth.go)Testing and validation:
web-authsecret command, including error cases, metadata options, and export functionality, ensuring robust and predictable behavior. (cmd/cli/create_secret_webauth_test.go)Closes: #551