Include exported inputs into drift event for ResourceSetInputProvider#852
Open
Mik4sa wants to merge 1 commit intocontrolplaneio-fluxcd:mainfrom
Open
Include exported inputs into drift event for ResourceSetInputProvider#852Mik4sa wants to merge 1 commit intocontrolplaneio-fluxcd:mainfrom
Mik4sa wants to merge 1 commit intocontrolplaneio-fluxcd:mainfrom
Conversation
Member
|
Let's wait and see what @stefanprodan says about this when he's back next week |
Co-authored-by: Copilot <copilot@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #850
Adds the new annotation
fluxcd.controlplane.io/eventMetadataExportedInputKeys. With it the user can control which fields from exported inputs are included in the event metadata for the Flux event (alert). Optionally the name of event metadata fields can be customized.What would it look like (for example for ResourceSetInputProvider
type: OCIArtifactTagand Microsoft Teams provider):No annotation
No behaviour change.

Annotation value: "tag,digest"
What I just realized. Here is the "digest" field missing. Is this a reserved name or so?
Annotation value: "tag=image-tag,digest=manifest-digest"
Multiple exported inputs
When there are multiple exported inputs (more than a single) then the index of the exported input is automatically added to the event metadata key:

Questions I ask myself but need feedback and guidance from you
eventMetadataExportedInputKeys?reconcile: enabled?Note:
The code changes aren't final yetbut functional complete in my eyes.@matheuscscp maybe you can have a look at this and give me your honest opinion?