Fixed wrong intersections splitting #24
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since it was used in two different places
Member
|
Yes, OSM data often contains duplicate nodes within a way. When you say you added a check for duplicate nodeids to osm-lib, do you mean you made a separate change to the osm-lib project? Is that a pull request? |
Contributor
Author
|
yes |
Member
|
Oh my mistake, I thought I was looking at a PR on R5, this is osm-lib. |
since non consecutive duplicated nodes are self intersection which are actual intersections.
Contributor
Author
|
I fixed PR so that only non consecutive duplicated nodes are removed in intersection detection. I also added tests that test specifically that. |
Member
|
Thanks @buma ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed when I was working on angles that there are some edges with 0 length. Most of those are because ways have duplicate nodeids. Same node ID appears twice one after another seems to be problem in OSM itself. In OTP there is also check for duplicate nodeids so I added one to osm-lib which fixes the problem with most 0-length edges.
Also added tests.