Support GeoJSON uploads for creating opportunity datasets. #902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevorgerhardt
force-pushed
the
allow-geojson-upload
branch
2 times, most recently
from
f71b880 to
ab7d1b6
Compare
trevorgerhardt
force-pushed
the
allow-geojson-upload
branch
from
ab7d1b6 to
162f29b
Compare
trevorgerhardt
force-pushed
the
allow-geojson-upload
branch
2 times, most recently
from
1b8ead8 to
c39100e
Compare
ansoncfit
reviewed
Feb 27, 2024
Member
ansoncfit
left a comment
ansoncfit
left a comment
There was a problem hiding this comment.
Based on a discussion last year, we might want to follow the approach in #761. If we're not going to switch to that workflow yet, it might be good at this stage to reduce some of the repetition here, by refactoring some of the fromShapefile code into reusable methods.
trevorgerhardt
force-pushed
the
allow-geojson-upload
branch
from
3db9bf7 to
9d9081f
Compare
Member
Author
This doesn't prevent or hinder following the approach in #761 whenever that is implemented.
Ok, I'll take a look and see if there is something to pull out there 👍 |
trevorgerhardt
force-pushed
the
allow-geojson-upload
branch
from
9d9081f to
cfe9fd3
Compare
trevorgerhardt
force-pushed
the
allow-geojson-upload
branch
from
cfe9fd3 to
4c8a8fd
Compare
trevorgerhardt
force-pushed
the
allow-geojson-upload
branch
from
4c8a8fd to
65a5e99
Compare
Closely mirrors the way Shapefiles are converted into grids. With GeoTools it is quite simple. It's possible to abstract common creation code between the two types but may not be necessary unless more types are added.
Co-authored-by: Anson Stewart <[email protected]>
trevorgerhardt
force-pushed
the
allow-geojson-upload
branch
from
65a5e99 to
be642f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closely mirrors the way Shapefiles are converted into grids.
Refs #747