Run traefik as non-root user #2217
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The diff looks good from here. Though I haven't launched it recently
|
|
IDK if the default redirect to HTTPS in #1992 is a bad way to accomplish
HTTPS-only whole (while it's not yet appropriate to add HTTP STS yet)?
IIRC, the regex replacement with port numbering took a second to get right.
Arguably, IMHO, it still makes sense to put nginx in front of traefik (or
whatever e.g. k8s/k3s ingress that can do WAF rules and HTTP request
normalization)
|
browniebroke
approved these changes
Sep 12, 2019
|
Thanks!
…On Thursday, September 12, 2019, Bruno Alla ***@***.***> wrote:
@browniebroke approved this pull request.
Just tested this and it works like a charm ✨
Thanks for taking the time to fix this 🙌
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Just got an email from the traefik seclist.
...
We're releasing Traefik 1.7.15 to fix the issue. In the meantime, we
strongly recommend that you set the TLS.minVersion option to TLS 1.2 on the
entrypoint configuration (
https://docs.traefik.io/configuration/entrypoints/#specify-minimum-tls-version
)
More technical information about this can be found at:
https://golang.org/doc/go1.13#crypto/tls
https://tools.ietf.org/html/rfc7568
|
Thank you for this, but it seems like a separate issue than the one being fixed here. Can it be tracked separately? @jayfk are we ok to merge this one? LGTM |
We might need to put a hold on this for now. I've seen some strange redirects happening running the config. We might need to add the redirect rules @westurner referenced on the original issue. Once I have a bit more time, I'll investigate. |
# Conflicts:
# {{cookiecutter.project_slug}}/compose/production/traefik/Dockerfile
# {{cookiecutter.project_slug}}/compose/production/traefik/traefik.toml
|
Is this still an issue? Linked to #2542? |
This was referenced Sep 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been brought up by @westurner, original issue is #1992
The PR adds a non-root user traefik and a traefik group and runs the container as this user. This makes it consistent with what we have in
compose/production/django/Dockerfile.Care to give it a spin @westurner?