Remove DATABASE_URL where possible#4862
Open
foarsitter wants to merge 5 commits into
Open
Conversation
foarsitter
force-pushed
the
remove_database_url
branch
from
August 27, 2024 08:43
2b74919 to
7d899c2
Compare
foarsitter
marked this pull request as ready for review
August 27, 2024 08:44
foarsitter
changed the title
foarsitter
requested review from
browniebroke
and removed request for
browniebroke
October 11, 2024 07:54
browniebroke
left a comment
browniebroke
left a comment
Member
There was a problem hiding this comment.
Looks good in principle, might be nice to see how it looks like after master is merged, as there was a few other changes
foarsitter
force-pushed
the
remove_database_url
branch
from
October 14, 2024 18:36
7d899c2 to
d275ac2
Compare
Co-authored-by: Bruno Alla <browniebroke@users.noreply.github.com>
# Conflicts:
# docs/2-local-development/developing-locally.rst
# {{cookiecutter.project_slug}}/compose/production/django/Dockerfile
| POSTGRES_USER: 'postgres' | ||
| POSTGRES_PASSWORD: 'postgres' | ||
| POSTGRES_DB: 'postgres' | ||
| POSTGRES_HOST: 'postgres' |
Member
There was a problem hiding this comment.
I think the host used to be localhost... Was it intentional or should we keep that?
Suggested change
| POSTGRES_HOST: 'postgres' | |
| POSTGRES_HOST: 'localhost' |
browniebroke
left a comment
browniebroke
left a comment
Member
There was a problem hiding this comment.
Should we replace this one too?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt the remove
DATABASE_URLenvironment variable.The only use case where
DATABASE_URLis required is when an application is hosted on heroku.