Change "body" to "main" in entrance.html #5410
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current setup for account sign up and signin loses the nav bar from the base.html
I am proposing we utilize the block
main
to regain the nav bar.Checklist:
The tests fail for me using main branch before this change, not sure its related
Rationale
Seems like the original purpose of the main block was to allow this.
entrance.html
already has a blockcontent
inside the html. Presumably to act as a base template for the allauth views.since our
base.html
relies on a blockcontent
, we now have duplicate names.In order to get around this issue of duplicate names,
base.html
blockcontent
is wrapped with blockmain
.This way another template using a block
content
can still extendbase.html
and keep the functionality of the nav bar, css, javascript and other behavior.Without this change (default), the sign up and sign in screens have no way to navigate back to the main page.