fix(complex): fix edge cases issues#23
Merged
Merged
Conversation
…ing labels
Three additional latent bugs surfaced when reviewing edge cases on top
of the previous commit:
- hpa.yaml: minReplicas falls back to $component.replicas which can
now be unset (since the previous commit hides .spec.replicas on the
Deployment when HPA is enabled). Without a further fallback the HPA
renders 'minReplicas: ' (empty) and gets rejected by kube-apiserver.
Chain to 'default 1' as the last resort.
- _pod.tpl: enableServiceLinks defaulted to the string "False" which
Go template renders verbatim ('enableServiceLinks: False'). K8s
accepts the bool-coercion but the type is wrong on the wire.
Switch to bool false. Also drop the commented-out securityContext
scaffold left in the template since it has no effect.
- keda-triggerauthentication.yaml: TriggerAuthentication resource was
rendered without any metadata.labels block, making it the only
cookielab-managed resource without standard labels. Add the same
cookielab.kubernetes.labels include used elsewhere.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
stepankonecny96
force-pushed
the
ai-fixed-fixes
branch
from
6e1f279 to
495e433
Compare
Patch bump covering the bug fixes in this PR (KEDA Kafka identityOwner logic, deployment replicas vs HPA drift, prometheusRule per-component naming, serviceaccount empty labels, cronjob lifecycle/restartPolicy, HPA minReplicas fallback, enableServiceLinks bool, KEDA TriggerAuthentication labels). README regenerated via helm-docs. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.