Fix stuck system proxy cleanup after VPN traffic drops offline#59
Open
FaustUser wants to merge 1 commit intocoolcoala:mainfrom
Open
Fix stuck system proxy cleanup after VPN traffic drops offline#59FaustUser wants to merge 1 commit intocoolcoala:mainfrom
FaustUser wants to merge 1 commit intocoolcoala:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This PR fixes a failure mode where the app could show VPN/proxy as disconnected in the UI, but the OS proxy settings remained active after the actual VPN traffic path had already broken.
The change updates
src/main/sys/sysproxy.tsso that:Why
Previously,
triggerSysProxy(false, ...)was gated bynet.isOnline(). In the broken-VPN scenario, the app could already consider the network offline, so disabling the VPN/proxy from the UI did not actually clear the system proxy. As a result, traffic kept going to an invalid local proxy endpoint and internet access did not recover until a reboot.Result
After this fix, turning VPN/proxy off performs cleanup deterministically even in degraded/offline states, which prevents the app from leaving the system in a stuck no-internet state.
Validation
npm run typecheck