fix(service): close edit domain modal after successful save - #10990
Open
devrim-1283 wants to merge 1 commit into
Open
fix(service): close edit domain modal after successful save#10990devrim-1283 wants to merge 1 commit into
devrim-1283 wants to merge 1 commit into
Conversation
EditDomain::submit() never dispatched the close-modal event that x-modal-input listens for, so the service Edit Domains modal stayed open after a successful save. Dispatch it on the success path only. Also make EditDomainPortValidationTest runnable in isolation and add the missing ServiceApplicationFactory. Co-Authored-By: Claude <noreply@anthropic.com>
devrim-1283
force-pushed
the
fix/service-edit-domain-modal-close
branch
from
July 28, 2026 13:48
abce7b2 to
7d3c484
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
close-modalevent the modal wrapper listens for. I dispatch it on the success path only, so the domain-conflict and required-port dialogs still behave as before — matching how the app's other modal forms close.Issues
Category
Preview
Before: the service "Edit Domains" modal stayed open after saving. After: it closes once the domain is saved.
AI Assistance
If AI was used:
Testing
php artisan test tests/Feature/Service/EditDomainPortValidationTest.php— 11 passed.Contributor Agreement
Important