fix(service): allow desktop app origins in Buzz template CORS - #11046
Open
Onnokh wants to merge 1 commit into
Open
fix(service): allow desktop app origins in Buzz template CORS#11046Onnokh wants to merge 1 commit into
Onnokh wants to merge 1 commit into
Conversation
BUZZ_CORS_ORIGINS only listed the web origin, so the Buzz desktop app could not reach a relay deployed from this template and reported "Load failed" when joining the community. The app is a Tauri webview and sends tauri://localhost on macOS or http://tauri.localhost on Windows/Linux — the pair Buzz documents in config.rs and hardcodes in media_proxy.rs. Signed-off-by: Onno Klein Hofmeijer <onnokh@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
BUZZ_CORS_ORIGINSin the Buzz template, so the Buzz desktop app can connectto the deployed relay.
Issues
two generated service-templates JSON files, which are a blocked path for
contributors; this one changes the template only.
Category
AI Assistance
If AI was used:
app failed with "Load failed" against my own self-hosted Buzz relay. The two
origins come from Buzz's own source, which documents them in its relay config
and hardcodes the same pair in the desktop media proxy. Verified on a live
deployment before opening this PR. Human-reviewed.
Testing
Deployed Buzz behind Coolify's proxy and compared CORS responses before and
after the change:
The desktop app went from "Load failed" to connecting normally, with no other
change. The relay parses the variable as a comma-separated list, so the existing
web origin is unaffected.
Contributor Agreement
Important