fix(proxy): preserve negation in non-root sudo conditions - #11088
Open
Arnaud-IFEA wants to merge 1 commit into
Open
fix(proxy): preserve negation in non-root sudo conditions#11088Arnaud-IFEA wants to merge 1 commit into
Arnaud-IFEA wants to merge 1 commit into
Conversation
Arnaud-IFEA
marked this pull request as ready for review
July 29, 2026 19:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
ifstatements executed on remote servers through a non-root SSH user.!operator beforesudo, producingif ! sudo docker ...instead of the invalidif sudo ! docker ....Issues
docker compose upis never executed (v4.0.0-beta.462) #8285Category
Preview
Before:
After:
AI Assistance
If AI was used:
Testing
vendor/bin/pint --dirty --format agentpassed under PHP 8.5.8.php artisan test --compact tests/Unit/ParseCommandsByLineForSudoTest.phppassed: 51 tests, 109 assertions.Contributor Agreement
Important