Skip to content

Improve --hostname=myhost to docker custom image #5551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 23, 2025
Merged

Improve --hostname=myhost to docker custom image #5551

merged 3 commits into from
Apr 23, 2025

Conversation

sebyx07
Copy link
Contributor

@sebyx07 sebyx07 commented Apr 4, 2025

Changes

  • allow --hostname=my-server to be passed

Issues

#5550

@sebyx07 sebyx07 force-pushed the add-hostname branch 2 times, most recently from 316d3b3 to f066607 Compare April 4, 2025 17:38
@sebyx07 sebyx07 changed the title Add hostname Add --hostname=myhost # to docker Apr 4, 2025
@sebyx07 sebyx07 changed the title Add --hostname=myhost # to docker Improve --hostname=myhost to docker custom image Apr 4, 2025
@sebyx07
Copy link
Contributor Author

sebyx07 commented Apr 4, 2025

this helps me with sidekiq(to give a better name to the workers) and sentry. and I think will help others too

@andrasbacsai
Copy link
Member

Thank you for the PR! I refactored a bit and now it works as it should.

@andrasbacsai andrasbacsai merged commit d6d76ad into coollabsio:next Apr 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebyx07 @andrasbacsai