fix(api): return correct status code for services #5564
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
megheaiulian
force-pushed
the
feat/correct-services-status-code
branch
2 times, most recently
from
43ec0cd to
c41ea9b
Compare
Services APIs do not return the correct status code. In some places we force status code 200 or 201 even when there are errors and we override the 40x status codes.
megheaiulian
force-pushed
the
feat/correct-services-status-code
branch
from
c41ea9b to
de84384
Compare
|
@andrasbacsai I know you're probably very busy and sorry about asking about this but can you please take a look at this 🙏 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Services APIs do not return the correct status code.
In some places we force status code 200 or 201 even when there are
errors and we override the 40x status codes.