Fix: Docker Cleanup stuck on "In Progress" #5633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v4.0.0-beta.408
chore(deps): update axios and dotenv versions in package-lock.json; bump realtime version to 1.0.7
v4.0.0-beta.409
This prevents queues from getting stuck when using the WithoutOverlapping middleware
|
Thank you for the PR! I add this to the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents queues from getting "stuck" when using the WithoutOverlapping middleware. This doesn't fix currently broken/stuck queues; for that, I have a manual method posed in issue #5074. This also does not fix queue's status from reporting "in progress" when it fails or crashes, this will just prevent the queue from getting stuck with an "eternal lock" that will prevent all future queues for that server UUID
Changes
->dontRelease()with->expireAfter(600)in the WithoutOverlapping middleware for theDockerCleanupJobIssues