Skip to content

fix(parsers): preserve custom volume drivers in Docker Compose parsing #7307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: next
Choose a base branch
from
Open

fix(parsers): preserve custom volume drivers in Docker Compose parsing #7307

wants to merge 2 commits into from
+263 −72

Conversation

@dan5py
Copy link
Contributor

@dan5py dan5py commented Nov 23, 2025

Changes

  • Fixed bug where custom volume drivers (CIFS, NFS, tmpfs, etc.) were being removed from Docker Compose files when mixed with regular volumes
  • Updated volume parsing logic in bootstrap/helpers/parsers.php to preserve any volume with driver_opts.type defined, instead of skipping them
  • Added unit tests in tests/Unit/DockerComposeCustomVolumeDriverPreservationTest.php covering:
    • SMB/CIFS volumes
    • NFS volumes
    • tmpfs volumes
    • Mixed custom and regular volumes

Issues

@dan5py dan5py changed the title refactor(parsers): preserve custom volume drivers in Docker Compose parsing fix(parsers): preserve custom volume drivers in Docker Compose parsing Nov 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dan5py