feat: add ServiceDatabase restore/import support #7540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for restoring/importing backups in ServiceDatabase (Docker Compose databases). Changes: - Add ServiceDatabase case in buildRestoreCommand() method - Handle ServiceDatabase container naming in getContainers() - Support PostgreSQL, MySQL, MariaDB, MongoDB detection via databaseType() - Mark unsupported ServiceDatabase types (Redis, KeyDB, etc.) Fixes coollabsio#7529
algora-pbc
bot
added
the
🙋 Bounty claim
Member
|
The target branch has to be |
ShadowArcanist
added
the
💤 Waiting for changes
Member
|
Application composes don't have the UI to support imports and backups at the moment. |
Add Import Backup section to ServiceDatabase view for supported database types (PostgreSQL, MySQL, MariaDB, MongoDB). This enables users to import backups directly from the ServiceDatabase configuration page, utilizing the existing Import Livewire component.
Contributor
Author
|
Thanks for the feedback! I've added the Import Backup UI to the ServiceDatabase configuration page for supported database types (PostgreSQL, MySQL, MariaDB, MongoDB). The import functionality uses the existing Import Livewire component. Full backup system (scheduled backups, backup execution views) would require more work - let me know if that's needed for this PR or should be a separate issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support for restoring/importing backups in ServiceDatabase (Docker Compose databases).
Changes
ServiceDatabasecase inbuildRestoreCommand()methodgetContainers()(usesname-service.uuidformat)databaseType()updatedDumpAll()to handle ServiceDatabase dump-all modeTechnical Details
The implementation uses the existing
ServiceDatabase::databaseType()method to detect the database type and build the appropriate restore command, following the same pattern as standalone databases.Testing
Related Issue
/claim #7529
Demo Video
(Will be added after testing)