feat: add docker compose include directive support#8850
Open
TupiC wants to merge 1 commit intocoollabsio:nextfrom
Open
feat: add docker compose include directive support#8850TupiC wants to merge 1 commit intocoollabsio:nextfrom
TupiC wants to merge 1 commit intocoollabsio:nextfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
git showto read the compose file from the object store: no longer need sparse-checkout, working tree or git version check since git show is available in all git versionsIssues
includesection for docker compose #2859 which got transformed to a discussion Support `include` section for docker compose #4049 : not only do these people need it, but I also think support for the include statement is a 'base' feature, since it has been available since docker compose version 2.20.3 and always using a workaround by replicating all services, volumes etc. in multiple docker compose files is laboriousCategory
Preview
suppose we have the following docker-compose.yml

the frontend/docker-compose.yml looks like this:

the backend/docker-compose.yml looks like this:

the include paths would get resolved and the correct directives get injected in the main docker compose which looks like this (raw):

AI Assistance
If AI was used:
Testing
also added unit tests for parsing and injecting
Contributor Agreement
Important