fix(logs): handle missing clipboard API in non-HTTPS contexts#8942
Open
devrim-1283 wants to merge 2 commits intocoollabsio:nextfrom
Open
fix(logs): handle missing clipboard API in non-HTTPS contexts#8942devrim-1283 wants to merge 2 commits intocoollabsio:nextfrom
devrim-1283 wants to merge 2 commits intocoollabsio:nextfrom
Conversation
navigator.clipboard is undefined in insecure contexts (HTTP), causing a silent TypeError when clicking the copy logs button. Added a secure context check and proper Promise chaining so failures surface as user- visible error messages instead of silent crashes. Affects deployment log view and shared get-logs component.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The copy-logs clipboard button was silently failing on HTTP instances. The clipboard API is only available in secure contexts (HTTPS or localhost). Calling writeText on undefined threw a TypeError that Alpine.js swallowed — the button appeared to do nothing with no user feedback.
Both deployment show and shared get-logs blade views had the same issue.
Issues
Category
Preview
No visual changes — behavior fix. On HTTP the error toast now appears instead of silently failing.
AI Assistance
If AI was used:
Testing
Contributor Agreement
Important