Add input delay#1267
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds a configurable input delay. Declares extern 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
damn that's sick INPUT_DELAY = "Atraso da entrada" |
|
German: INPUT_DELAY = "Eingabeverzögerung" |
Isaac0-dev
left a comment
There was a problem hiding this comment.
looks pretty good, here's some nitpicks. otherwise, we're just waiting on translations
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/game/game_init.c`:
- Around line 497-498: Clamp the computed delay to a non-negative value before
using it to index the buffer: replace the current upper-only clamp of delay
(using configInputDelay and INPUT_BUFFER_MAX_DELAY) with a clamp that enforces 0
<= delay <= INPUT_BUFFER_MAX_DELAY so tail calculation uses a non-negative
delay; adjust the assignment to delay (the variable computed from
configInputDelay) and then compute tail using sInputBufferHead,
INPUT_BUFFER_SIZE and INPUT_BUFFER_SIZE constants as before.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
|
conflicts |
|
merge conflicts |
has a max delay of 15 frames
need translations for
INPUT_DELAY = "Input Delay"