Remove NPOT texture check in DJUI#1329
Conversation
Doesn't seem to crash anymore, not needed, tested and NPOT textures work under both renderers (OpenGL and DX11)
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughIn 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
xLuigiGamerx
left a comment
There was a problem hiding this comment.
It's not just about whether it crashes or not, the engine just doesn't handle NPOT well, did you confirm that functions like djui_hud_render_texture_tile work correctly with it and with NPOT tilewidths and tileheights ans such
You're right, let me check that |
2026-06-24.18-41-27.mp42026-06-24.18-59-29.mp4A couple of examples of the interpolation and rendering functions working with NPOT textures, 201x212 for the FNAF logo and 200x200 for the heart icon. Works in tiled and regular textures, interpolated or not. @AgentXLP helped me out with the heart test since the other one was a bit hard to see and I wanted to make sure I was doing it right as well as checking with other setups. Should be good to go now and merge, but feel free to test under another OS maybe just in case. |
Doesn't seem to crash anymore, not needed, tested and NPOT textures work under both renderers (OpenGL and DX11)