-
-
Notifications
You must be signed in to change notification settings - Fork 209
feat(settings): custom shortcuts #1941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1941 +/- ##
==========================================
- Coverage 97.93% 97.93% -0.01%
==========================================
Files 53 53
Lines 5677 5705 +28
==========================================
+ Hits 5560 5587 +27
- Misses 117 118 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick initial review 🙂
4755fa8
to
e98bb4f
Compare
e98bb4f
to
2881060
Compare
So, back to this one !
This will mostly have impact on I will adjust this PR accordingly, but I need some decision and directions. |
IMO, it would be consistent to treat URLs identically when passed as a source to |
It makes the prefixes (currently
gh:
andgl:
) customizable using user settings, allowing to:It moves URL normalization into the settings to benefit from custom shortcuts.
Some decisions are required on the
vcs.get_repo()
behavior:it currently only assumes
https://gitlab
andhttps://github
are http git repositories, unless prefixed withgit+
.However, non git remotes are not supported, so I wonder if it would be simpler to consider all
https://
as git repositories (it would fail if this is not the case, whatever this method returns)