fix: decode external data file content explicitly as UTF-8#1973
Merged
sisp merged 1 commit intocopier-org:masterfrom Feb 18, 2025
Merged
fix: decode external data file content explicitly as UTF-8#1973sisp merged 1 commit intocopier-org:masterfrom
sisp merged 1 commit intocopier-org:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1973 +/- ##
=======================================
Coverage 97.89% 97.90%
=======================================
Files 53 53
Lines 5567 5575 +8
=======================================
+ Hits 5450 5458 +8
Misses 117 117
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f116c40 to
0ff1e82
Compare
pawamoy
approved these changes
Feb 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've fixed a string encoding/decoding bug on Windows that broke loading external data with non-ASCII characters. See #1970 for more details, as the root cause for this problem is the same.
I've verified that the new test is failing on Windows 11 without the fix:
Expand to view the
pytestlog