Skip to content

Improve instruction for multiselection variable #2034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

InAnYan
Copy link
Contributor

@InAnYan InAnYan commented Mar 13, 2025

Closes #2033.

The instruction was co-authored with @pawamoy.

Currently, I have two issues with this code:

  1. Instruction is too big.
  2. Is it okay to leave the instruction like this? Like a literal.

And yes, the instruction should be wrapped in parenthesis and shouldn't include a preceding space.

@yajo
Copy link
Member

yajo commented Mar 16, 2025

Please could you post a screenshot of how it looks now?

Copy link

codecov bot commented Mar 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.13%. Comparing base (6a6db81) to head (72c393a).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2034      +/-   ##
==========================================
+ Coverage   97.96%   98.13%   +0.16%     
==========================================
  Files          54       54              
  Lines        5807     5834      +27     
==========================================
+ Hits         5689     5725      +36     
+ Misses        118      109       -9     
Flag Coverage Δ
unittests 98.13% <100.00%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@InAnYan
Copy link
Contributor Author

InAnYan commented Mar 17, 2025

image

Oh, it's on a new line.

Hope I won't open a holy war for every character in this instruction...

@sisp
Copy link
Member

sisp commented Apr 25, 2025

Sorry for the delay. 🫣 I don't mind a new line for the instructions. Just an alternative idea for the arrow keys: How about using Unicode arrow characters, i.e. "↓↑ keys" instead of "arrow keys"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiselection hints are too obscure
3 participants