Skip to content

ci(release): fix building distributions without local version identifier#2110

Merged
sisp merged 1 commit intomasterfrom
ci/build-distributions-without-local-version
Apr 25, 2025
Merged

ci(release): fix building distributions without local version identifier#2110
sisp merged 1 commit intomasterfrom
ci/build-distributions-without-local-version

Conversation

@sisp
Copy link
Member

@sisp sisp commented Apr 25, 2025

I've fixed the override to omit local version identifiers when building distributions for publication on test.pypi.org. It turns out that hatch-vcs doesn't support all environment variables from setuptools-scm. 😞 The workaround is to patch pyproject.toml with the appropriate hatch-vcs setting that is passed through to setuptools-scm.

@codecov
Copy link

codecov bot commented Apr 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.01%. Comparing base (b85893d) to head (f8b1392).
Report is 98 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2110      +/-   ##
==========================================
+ Coverage   97.86%   98.01%   +0.15%     
==========================================
  Files          55       55              
  Lines        5949     5949              
==========================================
+ Hits         5822     5831       +9     
+ Misses        127      118       -9     
Flag Coverage Δ
unittests 98.01% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sisp sisp merged commit 72e180c into master Apr 25, 2025
21 checks passed
@sisp sisp deleted the ci/build-distributions-without-local-version branch April 25, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant