Skip to content

fix(migrations): use configurable Jinja delimiters for default migration condition#2584

Merged
sisp merged 1 commit intomasterfrom
fix/migration-default-condition
Mar 31, 2026
Merged

fix(migrations): use configurable Jinja delimiters for default migration condition#2584
sisp merged 1 commit intomasterfrom
fix/migration-default-condition

Conversation

@sisp
Copy link
Copy Markdown
Member

@sisp sisp commented Mar 31, 2026

I've fixed a bug related to rendering the default migration condition.

The default migration condition ({{ _stage == "after" }}) was built with hardcoded {{ and }} as variable start/end strings. When a template configured alternative delimiters via _envops such as

_envops:
  variable_start_string: "[["
  variable_end_string: "]]"

the default condition would contain the wrong delimiters and fail to render correctly.

The condition is now constructed using the delimiters resolved from the _envops settings in copier.yml, falling back to {{ and }} when not overridden.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.25%. Comparing base (f6ac946) to head (769a1a7).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2584   +/-   ##
=======================================
  Coverage   97.24%   97.25%           
=======================================
  Files          59       59           
  Lines        6826     6850   +24     
=======================================
+ Hits         6638     6662   +24     
  Misses        188      188           
Flag Coverage Δ
unittests 97.25% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sisp sisp merged commit 0b714d5 into master Mar 31, 2026
21 checks passed
@sisp sisp deleted the fix/migration-default-condition branch March 31, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant