Set Automatic-Module-Name: com.github.copilot.sdk.java in JAR manifest#191
Merged
Set Automatic-Module-Name: com.github.copilot.sdk.java in JAR manifest#191
Conversation
1 task
Co-authored-by: edburns <75821+edburns@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [FEAT] Set Automatic-Module-Name in MANIFEST.MF
Set Automatic-Module-Name: com.github.copilot.sdk.java in JAR manifest
Mar 12, 2026
edburns
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without an
Automatic-Module-Name, JPMS derives the module name from the JAR filename — fragile and liable to break across version bumps or artifact renames.Changes
pom.xml— Addedmaven-jar-plugin(v3.4.2) with a manifest entry declaringAutomatic-Module-Name: com.github.copilot.sdk.javaResulting
META-INF/MANIFEST.MF:Consumers can now safely write:
No source changes. JAR remains an automatic module (no
module-info.class).Pull request checklist
mvn spotless:applyhas been run to format the codemvn clean verifypasses locallyDoes this introduce a breaking change?
📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.