Hardcode some commands that should not clear the overlay #436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* copilot.el (copilot--hardcoded-clear-overlay-ignore-commands): New constant. (copilot--post-command): Use it.
bbatsov
reviewed
Dec 9, 2025
| :type '(repeat function) | ||
| :package-version '(copilot . "0.1")) | ||
|
|
||
| (defconst copilot--hardcoded-clear-overlay-ignore-commands |
Collaborator
There was a problem hiding this comment.
Perhaps "default" is a better term than "hardcoded"?
Contributor
Author
There was a problem hiding this comment.
I'm happy with whichever. "Default" sounds to me like the default value of the user option
Contributor
Author
There was a problem hiding this comment.
Would you prefer something like this?
(defconst copilot--clear-overlay-ignore-defaults
'(universal-argument digit-argument negative-argument universal-argument-more)
"Built-in list of commands that should not clear the overlay.")
Collaborator
There was a problem hiding this comment.
Not a big deal. This can always be changed.
bbatsov
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
constant.
(copilot--post-command): Use it.