[codex] Fix onboarding network selection race#4389
Draft
malsomesh9 wants to merge 1 commit into
Draft
Conversation
malsomesh9
force-pushed
the
codex/fix-3634-onboarding-network-race
branch
from
7c74d64 to
25ebf4a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the onboarding race behind issue #3634 where quickly selecting multiple networks could drop the earlier selection.
Root cause
The onboarding provider appended previewed wallet descriptors from an async callback using stale state captured before the first request finished, so later responses could overwrite earlier selections.
Changes
Validation
./node_modules/.bin/eslint packages/recoil/src/context/OnboardingProvider.tsx./node_modules/.bin/tsc -p packages/recoil/tsconfig.json --noEmit(repo-wide pre-existing build graph issues; did not complete cleanly in this fresh clone)