v45.0.0-cx.4: Take 2860ada from upstream (#20048) (#393)

fix: The limit_pushdown physical optimization rule removes limits in some cases leading to incorrect results (#20048)
## Which issue does this PR close?

<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases.
You can link an issue to this PR using the GitHub syntax. For example
`Closes #123` indicates that this PR will close issue #123.
-->

None

## Rationale for this change

<!--
Why are you proposing this change? If this is already explained clearly
in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand
your changes and offer better suggestions for fixes.
-->
Bug 1: When pushing down limits, we recurse down the physical plan
accumulating limits until we reach a node where we can't push the limit
down further. At this point, we insert another limit executor (or push
it into the current node, if that node supports it). After this, we
continue recursing to try to find more limits to push down. If we do
find another, we remove it, but we don't set the
`GlobalRequirements::satisfied` field back to false, meaning we don't
always re-insert this limit.

Bug 2: When we're pushing down a limit with a skip/offset and no
fetch/limit and we run into a node that supports fetch, we set
`GlobalRequirements::satisfied` to true. This is wrong: the limit is not
satisfied because fetch doesn't support skip/offset. Instead, we should
set `GlobalRequirements::satisfied` to true if skip/offset is 0.

## What changes are included in this PR?

<!--
There is no need to duplicate the description in the issue here but it
is sometimes worth providing a summary of the individual changes in this
PR.
-->
This includes a one-line change to the push down limit logic that fixes
the issue.

## Are these changes tested?

<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code

If tests are not included in your PR, please explain why (for example,
are they covered by existing tests)?
-->

I added a test that replicates the issue and fails without this change.

## Are there any user-facing changes?

<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
No
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->

v43.0.0-cx.4

What's Changed

• Fix PartialEq for ScalarFunctionExpr by @joroKr21 in #382

Full Changelog: v43.0.0-cx.3...v43.0.0-cx.4

v43.0.0-cx.3

What's Changed

• Fix PhysicalExpr hash by @joroKr21 in #381

Full Changelog: https://github.com/coralogix/arrow-datafusion/commits/v43.0.0-cx.3

v42.0.0-cx.18

Use partial aggregation schema for spilling to avoid column mismatch …

v42.0.0-cx.17

What's Changed

• Add JoinContext with JoinLeftData to TaskContext in HashJoinExec by @thinkharderdev in #300

Full Changelog: v42.0.0-cx.16...v42.0.0-cx.17

v42.0.0-cx.16

What's Changed

• Fix CoalescePartitionsExec proto serialization (apache#15824) by @joroKr21 in #299

Full Changelog: v42.0.0-cx.15...v42.0.0-cx.16

v42.0.0-cx.15 (DO NOT USE)

What's Changed

• Feat: Add fetch to CoalescePartitionsExec (apache#14499) by @joroKr21 in #298

Full Changelog: v42.0.0-cx.13...v42.0.0-cx.15

v42.0.0-cx.13

What's Changed

• Update arrow-rs dep to include rowid by @thinkharderdev in #295

Full Changelog: v42.0.0-cx.12...v42.0.0-cx.13

v42.0.0-cx.12

What's Changed

• Add fix for segfault in ByteGroupValueBuilder by @thinkharderdev in #294

Full Changelog: v42.0.0-cx.11...v42.0.0-cx.12

v42.0.0-cx.11

What's Changed

• Support aliases in ConstEvaluator (apache#14734) by @joroKr21 in #281
• Preserve the name of grouping sets in SimplifyExpressions by @joroKr21 in #282
• V42: Support Duration in min/max agg functions by @svranesevic in #284
• Fix panics in array_union by @joroKr21 in #286
• V42: Backport GroupsAccumulator for Duration min/max agg by @svranesevic in #289
• Fix array_sort for empty record batch by @joroKr21 in #291
• prost 0.13 by @mpurins-coralogix in #293

Full Changelog: https://github.com/coralogix/arrow-datafusion/commits/v42.0.0-cx.11