Config json schema generation #78
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NimrodAvni78
changed the title
NimrodAvni78
force-pushed
the
nimrodavni78/config-json-schema
branch
from
3acc24c to
3c6e393
Compare
pinoOgni
reviewed
Dec 16, 2025
cmd/obi-schema/main.go
Outdated
| for _, pkg := range packagesToScan { | ||
| pkgPath := filepath.Join(moduleRoot, pkg) | ||
| if err := scanPackageForEnums(pkgPath); err != nil { | ||
| fmt.Fprintf(os.Stderr, "Warning: error scanning %s: %v\n", pkg, err) |
Author
There was a problem hiding this comment.
yeah probably an error, will fix
pinoOgni
reviewed
Dec 16, 2025
cmd/obi-schema/main.go
Outdated
|
|
||
| func scanPackageForEnums(pkgPath string) error { | ||
| fset := token.NewFileSet() | ||
| pkgs, err := parser.ParseDir(fset, pkgPath, nil, parser.ParseComments) |
pinoOgni
requested changes
Dec 16, 2025
| @@ -133,6 +133,7 @@ type PrometheusConfig struct { | |||
|
|
|||
| // Registry is only used for embedding Beyla within the Grafana Agent. | |||
Author
There was a problem hiding this comment.
this is a beyla specific comment, becuase the embedding is beyla
so i left the comment but i added a new line so it wont be included in the schema
pinoOgni
approved these changes
Dec 16, 2025
mmat11
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Read DefaultConfig struct and attach default config
Some fields only specify in comments what their possible fields are, making them a Named String type can make the schema more accurate with enums
Checklist