kubeletstatsreceiver: set collect_all_network_interfaces on pods#178
Closed
cazorla19 wants to merge 4 commits into
Closed
kubeletstatsreceiver: set collect_all_network_interfaces on pods#178cazorla19 wants to merge 4 commits into
cazorla19 wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will continue fixing CDS-2133 by collecting pod network stats via
kubeletstatsreceiveralong with the node network stats.In original PR #173 I've enabled it only on the node-level for now, since enabling it on the pod-level will increase network metrics cardinality without any useful case for our users. Now, after the chart deployment on the user environment, the metric stats still look incomplete without this flag being set, i.e. it still blindly relies on
eth0interface name.This change should fix this issue.