[collector][supervisor] Fix custom image helper#218
Merged
Conversation
Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
douglascamata
requested review from
a team,
nicolastakashi and
oded-dd
as code owners
douglascamata
changed the title
Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
povilasv
approved these changes
Jun 12, 2025
douglascamata
added a commit
to coralogix/telemetry-shippers
that referenced
this pull request
Jun 13, 2025
…594) Fixes ES-629. Brings the fixes from coralogix/opentelemetry-helm-charts#218.
veronikaambar
pushed a commit
to coralogix/telemetry-shippers
that referenced
this pull request
Jun 27, 2025
…594) Fixes ES-629. Brings the fixes from coralogix/opentelemetry-helm-charts#218.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ES-629.
This PR fixes an issue in the image helper. Before we had the default Collector image hardcoded in values so it would always be picked even when the Supervisor preset was enabled. Now by default there is no image hardcoded in the values. This allows the helper logic to work correctly:
Unfortunately this bug happened because I was using a custom image repository during my tests without realizing.