rewrite presets.coralogixExporter.pipeline from string to array to allow enabling exporter on 2 pipelines at once#234
Merged
Conversation
…rray to allow enabling exporter on 2 pipelines at once
iblancasa
reviewed
Jul 2, 2025
douglascamata
requested changes
Jul 2, 2025
douglascamata
left a comment
Member
There was a problem hiding this comment.
Great job! I have two small suggestions.
Member
|
Something else, @cazorla19: can you please add one example for each of the options to helps us see how they behave? I think we might already have one with |
douglascamata
approved these changes
Jul 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CDS-2254
This change will add new variable
presets.coralogixExporter.pipelinesas anarrayofstringto allow enabling exporter on 2 pipelines at once.So that in cases where we want to disable, let's say, coralogix exporter only in one pipeline, we could do this:
instead of this:
We've added a new variable instead of changing the existing one (
presets.coralogixExporter.pipeline) for backward compatibility. The existing onepipelinewill be deprecated in the future. For now,pipelineSwill take precedence, whilepipelinewill be converted into array when set.